The Wednesday Wellness threads are meant to encourage users to ask for and provide advice and motivation to improve their lives. It isn't intended as a 'containment thread' and any content which could go here could instead be posted in its own thread. You could post:
-
Requests for advice and / or encouragement. On basically any topic and for any scale of problem.
-
Updates to let us know how you are doing. This provides valuable feedback on past advice / encouragement and will hopefully make people feel a little more motivated to follow through. If you want to be reminded to post your update, see the post titled 'update reminders', below.
-
Advice. This can be in response to a request for advice or just something that you think could be generally useful for many people here.
-
Encouragement. Probably best directed at specific users, but if you feel like just encouraging people in general I don't think anyone is going to object. I don't think I really need to say this, but just to be clear; encouragement should have a generally positive tone and not shame people (if people feel that shame might be an effective tool for motivating people, please discuss this so we can form a group consensus on how to use it rather than just trying it).
Jump in the discussion.
No email address required.
Notes -
Alternative: within some bounds of acceptability, there is no such thing as objectively good code, and you three are just trying to push your personal tastes onto each other. This would explain why no one seems to be able to convince any one else of their point of view, even in as seemingly objective a domain as CS.
You'll make spaghetti code and code debt just rubber stamping or giving minimal input on the reviews. My philosophy is to try to make it as easy on my future self or future coders as possible, because in my experience teams never have time to do refactoring or clean up work. There's always something else to make a priority.
To be less nitpicky sounding, I focus on the why of my comments. I try to explain what good it would do, with the level of detail I include based on the coder's level of experience. With a more senior dev, I may also ask why they chose to do it that way to see if there's something I'm missing. Basically, make it a conversation with learning opportunities. Mileage may vary with the results.
Give that a try, and if nothing improves then, yeah, slip in the rubber stamp and maybe start looking for another team. My current team lead talks a lot about good, clean, reusable, readable code and then in practice barely reviews code on my project and will add subpar code as a quick fix to a bug. I've lowered some of my expectations to cut back my frustration and sneak in a code cleanup here and there.
More options
Context Copy link
More options
Context Copy link